RE: [PATCH] ASoC: adau1977: remove platform data and move micbias bindings include
From: Ardelean, Alexandru
Date: Mon Oct 19 2020 - 09:39:23 EST
> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Monday, October 19, 2020 4:04 PM
> To: Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx;
> lgirdwood@xxxxxxxxx; lars@xxxxxxxxxx; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>;
> perex@xxxxxxxx; tiwai@xxxxxxxx
> Subject: Re: [PATCH] ASoC: adau1977: remove platform data and move micbias
> bindings include
>
> [External]
>
> On Mon, Oct 19, 2020 at 01:53:13PM +0300, Alexandru Ardelean wrote:
> > The change removes the platform_data include/definition. It only
> > contains some values for the MICBIAS.
> > These are moved into 'dt-bindings/sound/adi,adau1977.h' so that they
> > can be used inside device-trees. When moving then, they need to be
> > converted to pre-compiler defines, so that the DT compiler can understand
> them.
>
> This is missing an update of the binding documentation for the new property.
Umm, if referring to the 'adi,micbias' property, that isn't new:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/adi,adau1977.txt#n26
This just removes any left-over platform-data stuff; which admittedly should have been done earlier.
I also started a conversion of the old binding from text to yaml.
I'll probably have that ready in a couple of days.