Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it

[Matthieu Baerts]

Hi Geert,

Thank you for the patch!

On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> user may not want to enable.  Fix this by making the test depend on
> MPTCP instead.

I think the initial intension was to select MPTCP to have an easy way to 
enable all KUnit tests. We imitated what was and is still done in 
fs/ext4/Kconfig.

But it probably makes sense to depend on MPTCP instead of selecting it. 
So that's fine for me. But then please also send a patch to ext4 
maintainer to do the same there.

Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net