Re: [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments
From: Alan Stern
Date: Mon Oct 19 2020 - 12:28:22 EST
On Mon, Oct 19, 2020 at 12:06:37PM +0200, Thomas Gleixner wrote:
> From: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx>
>
> The usage of in_interrupt() in drivers is phased out for various reasons.
>
> Various comments use !in_interrupt() to describe calling context for probe()
> and remove() functions. That's wrong because the calling context has to be
> preemptible task context, which is not what !in_interrupt() describes.
>
> Cleanup the comments. While at it add the missing kernel doc argument
> descriptors.
>
> Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> ---
> V2: Split out the static change and add a missing comment
> ---
> drivers/usb/host/ehci-fsl.c | 9 ++++-----
> drivers/usb/host/ehci-pmcmsp.c | 11 +++++++----
> drivers/usb/host/ohci-at91.c | 11 ++++++++---
> drivers/usb/host/ohci-omap.c | 9 ++++++---
> drivers/usb/host/ohci-pxa27x.c | 11 ++++++-----
> drivers/usb/host/ohci-s3c2410.c | 12 ++++++------
> 6 files changed, 37 insertions(+), 26 deletions(-)
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>