Re: [PATCH] drm: remove unneeded break

From: Sam Ravnborg
Date: Mon Oct 19 2020 - 13:06:48 EST


Hi Tom
On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Looks good and builds with no warnings.

One of the diffs made me - "oh this looks wrong". But after I looked again
it was right and the resulting code is more readable - so good.

Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Was tempted to just apply to drm-misc-next but will give others the
opportunity to chime in.

Sam