RE: [PATCH v2 0/5] Remove LPC register partitioning

[ChiaWei Wang]

Hi All,

Do you have any comment on the v2 changes?
Thanks.

Chiawei

> -----Original Message-----
> From: ChiaWei Wang <chiawei_wang@xxxxxxxxxxxxxx>
> Sent: Monday, October 5, 2020 4:28 PM
> To: lee.jones@xxxxxxxxxx; robh+dt@xxxxxxxxxx; joel@xxxxxxxxx;
> andrew@xxxxxxxx; minyard@xxxxxxx; arnd@xxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; linus.walleij@xxxxxxxxxx;
> haiyue.wang@xxxxxxxxxxxxxxx; cyrilbur@xxxxxxxxx; rlippert@xxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; openbmc@xxxxxxxxxxxxxxxx;
> linux-gpio@xxxxxxxxxxxxxxx
> Subject: [PATCH v2 0/5] Remove LPC register partitioning
> 
> The LPC controller has no concept of the BMC and the Host partitions.
> The incorrect partitioning can impose unnecessary range restrictions on
> register access through the syscon regmap interface.
> 
> For instance, HICRB contains the I/O port address configuration of KCS channel
> 1/2. However, the KCS#1/#2 drivers cannot access HICRB as it is located at the
> other LPC partition.
> 
> In addition, to be backward compatible, the newly added HW control bits could
> be located at any reserved bits over the LPC addressing space.
> 
> Thereby, this patch series aims to remove the LPC partitioning for better driver
> development and maintenance.
> 
> 
> Changes since v1:
> 	- Add the fix to the aspeed-lpc binding documentation.
> 
> Chia-Wei, Wang (5):
>   ARM: dts: Remove LPC BMC and Host partitions
>   soc: aspeed: Fix LPC register offsets
>   ipmi: kcs: aspeed: Fix LPC register offsets
>   pinctrl: aspeed-g5: Fix LPC register offsets
>   dt-bindings: aspeed-lpc: Remove LPC partitioning
> 
>  .../devicetree/bindings/mfd/aspeed-lpc.txt    |  85 ++---------
>  arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
>  arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
>  arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
>  drivers/char/ipmi/kcs_bmc_aspeed.c            |  13 +-
>  drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |   2 +-
>  drivers/soc/aspeed/aspeed-lpc-ctrl.c          |   6 +-
>  drivers/soc/aspeed/aspeed-lpc-snoop.c         |  11 +-
>  8 files changed, 176 insertions(+), 285 deletions(-)
> 
> --
> 2.17.1