Re: [PATCH] lib: add basic KUnit test for lib/math
From: Andy Shevchenko
Date: Tue Oct 20 2020 - 04:08:48 EST
On Mon, Oct 19, 2020 at 03:45:56PM -0700, Daniel Latypov wrote:
> Add basic test coverage for files that don't require any config options:
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
>
> These tests aren't particularly interesting, but
> * they're chosen as easy to understand examples of how to write tests
> * provides a place to add tests for any new files in this dir
> * written so adding new test cases to cover edge cases should be easy
Is documentation not enough?
I have recently wrote my first KUnit test and I found documentation pretty good
for the start. I think we actually need more complex examples in the code (and
useful).
So, I'm in doubt these test are a good point to start with.
--
With Best Regards,
Andy Shevchenko