RE: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()

[Joakim Zhang]

Hi Marc,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: 2020年10月20日 17:31
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; robh+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Ying Liu
> <victor.liu@xxxxxxx>; linux-can@xxxxxxxxxxxxxxx; Pankaj Bansal
> <pankaj.bansal@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()
> 
> On 10/20/20 5:53 PM, Joakim Zhang wrote:
> > Disable wakeup in flexcan_remove().
> 
> The patch looks good, please explain why this is needed.

Okay, Can I resend this patch individually?

Joakim
> Marc
> 
> >
> > Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
> > Fixes: 915f9666421c ("can: flexcan: add support for DT property
> > 'wakeup-source'")
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> > ---
> >  drivers/net/can/flexcan.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> > index 06f94b6f0ebe..881799bd9c5e 100644
> > --- a/drivers/net/can/flexcan.c
> > +++ b/drivers/net/can/flexcan.c
> > @@ -2062,6 +2062,8 @@ static int flexcan_remove(struct platform_device
> > *pdev)  {
> >  	struct net_device *dev = platform_get_drvdata(pdev);
> >
> > +	device_set_wakeup_enable(&pdev->dev, false);
> > +	device_set_wakeup_capable(&pdev->dev, false);
> >  	unregister_flexcandev(dev);
> >  	pm_runtime_disable(&pdev->dev);
> >  	free_candev(dev);
> >
> 
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |