Re: [PATCH 5/6] media: dt-bindings: media: qcom,camss: Add bindings for SDM660 camss
From: Robert Foss
Date: Tue Oct 20 2020 - 06:34:14 EST
Looks good to me.
Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
On Sun, 18 Oct 2020 at 14:53, <kholk11@xxxxxxxxx> wrote:
>
> From: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx>
>
> Add bindings for qcom,sdm660-camss in order to support the camera
> subsystem on SDM630/660 and SDA variants.
>
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/qcom,camss.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt b/Documentation/devicetree/bindings/media/qcom,camss.txt
> index 09eb6ed99114..498234629e21 100644
> --- a/Documentation/devicetree/bindings/media/qcom,camss.txt
> +++ b/Documentation/devicetree/bindings/media/qcom,camss.txt
> @@ -8,6 +8,7 @@ Qualcomm Camera Subsystem
> Definition: Should contain one of:
> - "qcom,msm8916-camss"
> - "qcom,msm8996-camss"
> + - "qcom,sdm660-camss"
> - reg:
> Usage: required
> Value type: <prop-encoded-array>
> @@ -64,30 +65,36 @@ Qualcomm Camera Subsystem
> Value type: <stringlist>
> Definition: Should contain the following entries:
> - "top_ahb"
> + - "throttle_axi" (660 only)
> - "ispif_ahb"
> - "csiphy0_timer"
> - "csiphy1_timer"
> - "csiphy2_timer" (8996 only)
> + - "csiphy_ahb2crif" (660 only)
> - "csi0_ahb"
> - "csi0"
> - "csi0_phy"
> - "csi0_pix"
> - "csi0_rdi"
> + - "cphy_csid0" (660 only)
> - "csi1_ahb"
> - "csi1"
> - "csi1_phy"
> - "csi1_pix"
> - "csi1_rdi"
> + - "cphy_csid1" (660 only)
> - "csi2_ahb" (8996 only)
> - "csi2" (8996 only)
> - "csi2_phy" (8996 only)
> - "csi2_pix" (8996 only)
> - "csi2_rdi" (8996 only)
> + - "cphy_csid2" (660 only)
> - "csi3_ahb" (8996 only)
> - "csi3" (8996 only)
> - "csi3_phy" (8996 only)
> - "csi3_pix" (8996 only)
> - "csi3_rdi" (8996 only)
> + - "cphy_csid3" (660 only)
> - "ahb"
> - "vfe0"
> - "csi_vfe0"
> --
> 2.28.0
>