Re: [PATCH 4/4] scsi: add more contexts in the ufs tracepoints

[Can Guo]

On 2020-10-20 19:02, Can Guo wrote:
> On 2020-10-20 18:51, Avri Altman wrote:
> > > On 2020-10-06 06:36, Jaegeuk Kim wrote:
> > > > From: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> > > >
> > > > This adds user-friendly tracepoints with group id.
> > You have the entire cdb as part of the upiu trace,
> > Can't you parse what you need from there?
> >
> > Thanks,
> > Avri
>
> Yes, but assume we have a large trace log file, having a
> groud id allows us to filter the data by it easily, right?
>
> Thanks,
>
> Can Guo.

I just dobule checked WRITE(10)'s CDB, byte 6 has group
ID ONLY. So Avri is right, we don't even need to parse it,
we can easily filter a ftrace log file by byte 6 to get the
WRITE(10) cmds with specific group ID - we don't need this
change.

Thanks,

Can Guo.