Re: [PATCH net v2] Revert "virtio-net: ethtool configurable RXCSUM"

From: Jakub Kicinski
Date: Tue Oct 20 2020 - 17:44:40 EST


On Tue, 20 Oct 2020 07:45:09 -0400 Michael S. Tsirkin wrote:
> On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote:
> > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote:
> > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8.
> > >
> > > When the device does not have a control vq (e.g. when using a
> > > version of QEMU based on upstream v0.10 or older, or when specifying
> > > ctrl_vq=off,ctrl_rx=off,ctrl_vlan=off,ctrl_rx_extra=off,ctrl_mac_addr=off
> > > for the device on the QEMU command line), that commit causes a crash:
> >
> > Hi Michael!
> >
> > Only our very first (non-resend) version got into patchwork:
> >
> > https://patchwork.ozlabs.org/project/netdev/list/?submitter=2235&state=*
> >
> > Any ideas why?
>
> I really don't! Any ideas?

No idea. I have a local instance of patchwork to test things, and it
didn't pick your patch up either. Weird.

Looks like there will be v3, let's not worry about it for this single
patch, worst case I'll pick it up from inbox or lore.