Re: [PATCH v2] power: suspend: Replace dpm_watchdog by sleep timer

From: Rafael J. Wysocki
Date: Wed Oct 21 2020 - 05:51:42 EST


On Wed, Oct 21, 2020 at 4:09 AM Joseph Jang <josephjang@xxxxxxxxxx> wrote:
>
> Since dpm_watchdog just cover device power management, we proposed sleep
> timer to cover not only device power management hang issues, but also
> core power management hand issue.
>
> Add sleep timer and timeout handler to prevent device stuck during suspend/
> resume process. The timeout handler will dump disk sleep task at first
> round timeout and trigger kernel panic at second round timeout.
> The default timer for each round is defined in
> CONFIG_PM_SLEEP_TIMER_TIMEOUT.

Let me repeat the point that Greg has made already: Please don't
replace the existing watchdog with something else, but try to extend
it to cover your use case.

As it stands, the patch is not applicable IMV.

Thanks!