Re: [PATCH] gpio: bd70528: remove unneeded break

[Vaittinen, Matti]

Hello,

On Wed, 2020-10-21 at 07:39 -0700, Joe Perches wrote:
> On Wed, 2020-10-21 at 07:25 +0000, Vaittinen, Matti wrote:
> > Hello Joe & All,
> > On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote:
> > > On Tue, 2020-10-20 at 11:48 +0000, Vaittinen, Matti wrote:
> []
> > > > And for peeps who have not been following - following function
> > > > triggers the checkpatch error above:
> > > 
> > > Huh?  what version of checkpatch are you using?
> > > Send it to me please.
> []
> > Please find my version of checkpatch and the patch to trigger the
> > warning attached.
> 
> Thanks.  This test wasn't particularly useful
> (and had some false positives) and was removed by
> 
> commit ef3c005c0eb07a60949191bc6ee407d5f43cc502
> Author: Joe Perches <joe@xxxxxxxxxxx>
> Date:   Tue Aug 11 18:35:19 2020 -0700
> 
>     checkpatch: remove missing switch/case break test
>     
>     This test doesn't work well and newer compilers are much better
>     at emitting this warning.
>     
>     Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>     Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>     Cc: Cambda Zhu <cambda@xxxxxxxxxxxxxxxxx>
>     Link: 
> http://lkml.kernel.org/r/7e25090c79f6a69d502ab8219863300790192fe2.camel@xxxxxxxxxxx
>     Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> 

Thanks for checking this Joe!
And note to self - always check with newest kernel... ;)

(Sorry for bothering)

Br,
	Matti Vaittinen