Re: [PATCH] acpi: utils: remove unneeded break

From: Rafael J. Wysocki
Date: Thu Oct 22 2020 - 13:00:14 EST


On Mon, Oct 19, 2020 at 10:05 PM <trix@xxxxxxxxxx> wrote:
>
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/acpi/utils.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 838b719ec7ce..d5411a166685 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -104,7 +104,6 @@ acpi_extract_package(union acpi_object *package,
> " [%c]\n",
> i, format_string[i]);
> return AE_BAD_DATA;
> - break;
> }
> break;
>
> @@ -129,7 +128,6 @@ acpi_extract_package(union acpi_object *package,
> " expecting [%c]\n",
> i, format_string[i]);
> return AE_BAD_DATA;
> - break;
> }
> break;
> case ACPI_TYPE_LOCAL_REFERENCE:
> @@ -144,7 +142,6 @@ acpi_extract_package(union acpi_object *package,
> " expecting [%c]\n",
> i, format_string[i]);
> return AE_BAD_DATA;
> - break;
> }
> break;
>
> @@ -155,7 +152,6 @@ acpi_extract_package(union acpi_object *package,
> i));
> /* TBD: handle nested packages... */
> return AE_SUPPORT;
> - break;
> }
> }
>
> --

Applied as 5.10-rc material with subject and changelog edits, thanks!