Re: [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put()

From: Andy Shevchenko
Date: Thu Oct 22 2020 - 14:45:55 EST


On Thu, Oct 22, 2020 at 9:06 PM Nicolas Saenz Julienne
<nsaenzjulienne@xxxxxxx> wrote:
>
> When unbinding the firmware device we need to make sure it has no
> consumers left. Otherwise we'd leave them with a firmware handle
> pointing at freed memory.
>
> Keep a reference count of all consumers and make sure they all finished
> unbinding before we do.

Wait, if it's a device, why do we need all these?
get_device() / put_device() along with module_get() / module_put()
should be sufficient, no?

--
With Best Regards,
Andy Shevchenko