Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

[Kai-Heng Feng]

> On Oct 23, 2020, at 19:34, Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> On Fri, 23 Oct 2020 12:23:36 +0200,
> Kai-Heng Feng wrote:
>> 
>> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev)
>> 		__azx_runtime_suspend(chip);
>> 	else
>> 		pm_runtime_force_suspend(dev);
>> -	if (bus->irq >= 0) {
>> -		free_irq(bus->irq, chip);
>> -		bus->irq = -1;
>> -		chip->card->sync_irq = -1;
>> -	}
> 
> This release of irq has nothing to do with MSI.  There has been PCI
> controllers that assign to a different IRQ line after the resume.

Can this issue happened before commit 41017f0cac925 ("[PATCH] PCI: MSI(X) save/restore for suspend/resume") was merged?

Kai-Heng

> 
>> -	if (azx_acquire_irq(chip, 1) < 0)
>> -		return -EIO;
> 
> Ditto.
> 
> 
> thanks,
> 
> Takashi