Re: [PATCH v5] checkpatch: extend attributes check to handle more patterns

From: Dwaipayan Ray
Date: Sun Oct 25 2020 - 14:27:52 EST


On Sun, Oct 25, 2020 at 11:49 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote:
> > On Sun, Oct 25, 2020 at 11:29 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> []
> > > Using $rawline would also change comments and that seems wrong.
> > > Any reason to use $rawline instead of $line?
> > Yes I used $line initially but changed it because quoted
> > strings were being replaced.
> >
> > Like:
> > __attribute__((__section__("_ftrace_events")))
>
> Right thanks, that's a very sensible tradeoff to reduce code complexity.
>

Okay. Do you see anything else that I should cover in the next
iteration?

If there is no other problem, I will do the space addition one and
resend it to you.

Thanks,
Dwaipayan.