Re: [PATCH v1 2/6] dt-bindings: arm: cpus: Document 'mtk,freq-domain' property
From: Hector Yuan
Date: Mon Oct 26 2020 - 02:13:38 EST
On Fri, 2020-10-23 at 11:20 -0500, Rob Herring wrote:
> +Sudeep
>
> On Fri, Oct 23, 2020 at 04:24:49PM +0800, Hector Yuan wrote:
> > From: "Hector.Yuan" <hector.yuan@xxxxxxxxxxxx>
> >
> > Add devicetree documentation for 'mtk,freq-domain' property specific
> > to Mediatek CPUs. This property is used to reference the CPUFREQ node
> > along with the domain id.
>
> Okay, now we've got the same thing being done for Mediatek, QCom, and
> SCMI. This needs to be a common binding.
>
OK, thank you. I will pay attention for this. But still
"mediatek,freq-domain" in v8.
> > Signed-off-by: Hector.Yuan <hector.yuan@xxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> > index 1222bf1..06a6f5b 100644
> > --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> > @@ -255,6 +255,12 @@ properties:
> >
> > where voltage is in V, frequency is in MHz.
> >
> > + mtk-freq-domain:
>
> I expect this to change, but still not right form: <vendor>,<prop name>
>
> mtk is not the registered vendor.
>
OK, will modify this in v8.(use the previous pacthset and merge all
changes)
> > + $ref: '/schemas/types.yaml#/definitions/phandle-array'
> > + description:
> > + CPUs supporting freq-domain must set their "mtk-freq-domain" property
> > + with phandle to a cpufreq_hw node followed by the domain id.
> > +
> > power-domains:
> > $ref: '/schemas/types.yaml#/definitions/phandle-array'
> > description:
> > --
> > 1.7.9.5