Re: [PATCH v2 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

From: Rob Herring
Date: Mon Oct 26 2020 - 09:37:57 EST


On Mon, Oct 19, 2020 at 06:44:28PM +0530, Akhil P Oommen wrote:
> Add cooling device support to gpu. A cooling device is bound to a
> thermal zone to allow thermal mitigation.
>
> Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt
> index 1af0ff1..a496381 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt
> @@ -39,6 +39,10 @@ Required properties:
> a4xx Snapdragon SoCs. See
> Documentation/devicetree/bindings/sram/qcom,ocmem.yaml.
>
> +Optional properties:
> +- #cooling-cells: The value must be 2. Please refer
> + Documentation/devicetree/bindings/thermal/thermal.txt for detail.

This file doesn't exist anymore.

> +
> Example 3xx/4xx:
>
> / {
> @@ -61,6 +65,7 @@ Example 3xx/4xx:
> power-domains = <&mmcc OXILICX_GDSC>;
> operating-points-v2 = <&gpu_opp_table>;
> iommus = <&gpu_iommu 0>;
> + #cooling-cells = <2>;
> };
>
> gpu_sram: ocmem@fdd00000 {
> @@ -98,6 +103,8 @@ Example a6xx (with GMU):
> reg = <0x5000000 0x40000>, <0x509e000 0x10>;
> reg-names = "kgsl_3d0_reg_memory", "cx_mem";
>
> + #cooling-cells = <2>;
> +
> /*
> * Look ma, no clocks! The GPU clocks and power are
> * controlled entirely by the GMU
> --
> 2.7.4
>