Re: [PATCH] pinctrl: amd: print debounce filter info in debugfs

From: Coiby Xu
Date: Mon Oct 26 2020 - 11:17:09 EST


On Sun, Oct 25, 2020 at 07:12:16PM +0200, Andy Shevchenko wrote:
On Sat, Oct 24, 2020 at 2:32 PM Coiby Xu <coiby.xu@xxxxxxxxx> wrote:

Print out the status of debounce filter as follows,
$ cat /sys/kernel/debug/gpio|grep pin130
pin130 interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state|
disable wakeup in S4/S5 state| input is high| pull-up is disabled| Pull-down is disabled| output is disabled| debouncing filter (high) enabled| debouncing timeout is 124800 (us)| 0x503c8


+ if (!tmr_large) {
+ if (!tmr_out_unit)
+ unit = 61;
+ else
+ unit = 244;
+ } else {
+ if (!tmr_out_unit)
+ unit = 15600;
+ else
+ unit = 62500;
+ }

In all three if:s can you use positive conditionals?

Thank you for the suggestion! I've reversed the order of debounce
timeout in v2.

--
With Best Regards,
Andy Shevchenko

--
Best regards,
Coiby