Re: [PATCH v2] tty: serial: imx: remove unneeded break

From: Uwe Kleine-König
Date: Mon Oct 26 2020 - 12:33:03 EST


Hello,

On Tue, Oct 20, 2020 at 06:07:09AM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Just for the record: I commented for v1:

> this might be subjective, but I like the break being there for clearity.
> So I object to make a patch to remove them. In case I'm outvoted I'd at
> least want empty lines instead.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature