Re: [PATCH] seqlock: avoid -Wshadow warnings
From: Peter Zijlstra
Date: Mon Oct 26 2020 - 12:58:16 EST
On Mon, Oct 26, 2020 at 05:50:38PM +0100, Arnd Bergmann wrote:
> - unsigned seq; \
> + unsigned __seq; \
> - unsigned seq = __read_seqcount_begin(s); \
> + unsigned _seq = __read_seqcount_begin(s); \
> - unsigned seq = __seqcount_sequence(s); \
> + unsigned __seq = __seqcount_sequence(s); \
Can we have a consistent number of leading '_' ?
Also, I suppose you're going to find the explicit shadow in
___wait_event(), that one's not going to be trivial to fix.