Re: [PATCH] crypto: atmel-sha: remove unneeded break

From: Alexandre Belloni
Date: Mon Oct 26 2020 - 16:43:13 EST


On 19/10/2020 12:36:53-0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
Reviewed-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

> ---
> drivers/crypto/atmel-sha.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 75ccf41a7cb9..0eb6f54e3b66 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
> break;
> default:
> return -EINVAL;
> - break;
> }
>
> ctx->bufcnt = 0;
> --
> 2.18.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com