Re: [PATCH] asm-generic: percpu: avoid Wshadow warning

From: Luc Van Oostenryck
Date: Mon Oct 26 2020 - 17:03:18 EST


On Mon, Oct 26, 2020 at 04:53:48PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Nesting macros that use the same local variable names causes
> warnings when building with "make W=2":
>
> include/asm-generic/percpu.h:117:14: warning: declaration of '__ret' shadows a previous local [-Wshadow]
> include/asm-generic/percpu.h:126:14: warning: declaration of '__ret' shadows a previous local [-Wshadow]
>
> These are fairly harmless, but since the warning comes from
> a global header, the warning happens every time the headers
> are included, which is fairly annoying.
>
> Rename the variables to avoid shadowing and shut up the warning.

Looks good to me. Fell free to add my:

Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>