Re: [PATCH v2] hwmon: add Corsair PSU HID controller driver

From: Guenter Roeck
Date: Mon Oct 26 2020 - 17:22:47 EST


On Mon, Oct 26, 2020 at 08:29:53PM +0100, Wilken Gottwalt wrote:
> On Mon, 26 Oct 2020 11:41:51 -0700
> Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > I have to admit that it is quite new for me as well, but I find it convenient.
> > And it is kind of odd tht it needs three dots (and it may need spaces before
> > and after the '...').
>
> Well, the spaces make sense. Without it the syntax would conflict with the
> the float formats ".1" and "1.". Though I looked up at least 5 different
> c/c++ references and it wasn't mentioned in any of them. I often use this
> three dot syntax in c++ variadic template functions, but this is a bit
> different. I wonder if this is gcc specific.
>
Unlikely, because it is usd in various places and the kernel compiles with
clang.

> Is it okay if I switch my email address in the next version of the patch?
> I mean, is there a best practice for this case? My secure email provider
> insists on encrypted smtp transport and caches the most secure cipher
> encountered and the TLS options for vger.kernel.org changed 20+ hours ago.
> Since then not a single mail sent to vger arrived. You may have noticed it.
> Looks like I have to learn LKML submitting the most hard way. :-D
>
Ah, that explains why v2 of your patch did not make it into patchwork.

No problem if you change the e-mail address, as long as you keep your name.

Guenter