Re: [PATCH] ath10k: add option for chip-id based BDF selection

[Doug Anderson]

Hi,

On Sat, Oct 24, 2020 at 9:40 AM Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote:
>
> >         if (bd_ie_type == ATH10K_BD_IE_BOARD) {
> > +               /* With variant and chip id */
> >                 ret = ath10k_core_create_board_name(ar, boardname,
> > -                                                   sizeof(boardname), true);
> > +                                               sizeof(boardname), true, true);
>
> Instead of adding a lot of code to generate a second fallback name, its better to just modify the condition inside the function “ath10k_core_create_board_name” to allow the generation of BDF tag using chip id, even “if ar->id.bdf_ext[0] == '\0 “.
>
> This will make sure that the variant string is NULL, and just board-id and chip-id is used. This will help avoid most of the code changes.
> The code would look as shown below
>
> @@ -1493,7 +1493,7 @@ static int ath10k_core_create_board_name(struct ath10k *ar, char *name,
>         }
>
>         if (ar->id.qmi_ids_valid) {
> -               if (with_variant && ar->id.bdf_ext[0] != '\0')
> +               if (with_variant)

Wouldn't the above just be "if (with_chip_id)" instead?  ...but yeah,
that would be a cleaner way to do this.  Abhishek: do you want to post
a v2?

-Doug