Re: [PATCH] vsock: use ns_capable_noaudit() on socket create

[Jakub Kicinski]

On Tue, 27 Oct 2020 07:37:37 +1100 (AEDT) James Morris wrote:
> On Fri, 23 Oct 2020, Jeff Vander Stoep wrote:
> 
> > During __vsock_create() CAP_NET_ADMIN is used to determine if the
> > vsock_sock->trusted should be set to true. This value is used later
> > for determing if a remote connection should be allowed to connect
> > to a restricted VM. Unfortunately, if the caller doesn't have
> > CAP_NET_ADMIN, an audit message such as an selinux denial is
> > generated even if the caller does not want a trusted socket.
> > 
> > Logging errors on success is confusing. To avoid this, switch the
> > capable(CAP_NET_ADMIN) check to the noaudit version.
> > 
> > Reported-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> > https://android-review.googlesource.com/c/device/generic/goldfish/+/1468545/
> > Signed-off-by: Jeff Vander Stoep <jeffv@xxxxxxxxxx>  
> 
> Reviewed-by: James Morris <jamorris@xxxxxxxxxxxxxxxxxxx>

Applied to net, thanks!