Re: [PATCH 2/2] i2c: imx: remove id_table entry

[Greg Ungerer]

On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@xxxxxxx wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > The legacy platform device code has been removed under arch/arm/mach-imx,
> > so we no need id_table entry here.
>
> Cc: Greg, Geert, Angelo,
>
> Aren't you breaking Coldfire platforms?

Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.

Regards
Greg


> Best regards,
> Krzysztof
>
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> >   drivers/i2c/busses/i2c-imx.c | 14 --------------
> >   1 file changed, 14 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> > index ba9d639223ec..7ea36a78abb0 100644
> > --- a/drivers/i2c/busses/i2c-imx.c
> > +++ b/drivers/i2c/busses/i2c-imx.c
> > @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
> >   
> >   };
> >   
> > -static const struct platform_device_id imx_i2c_devtype[] = {
> > -	{
> > -		.name = "imx1-i2c",
> > -		.driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
> > -	}, {