Re: [RESEND PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one

[Keita Suzuki]

Hi Martin,

Thanks for the review.

> I suggest you submit a fix for just the leak. And then, if the hpsa
> maintainers agree, we can entertain a separate patch to improve the
> naming.

I'll revert the labels to numbered labels and resend the patch.

Thanks,
Keita

2020年10月27日(火) 6:49 Martin K. Petersen <martin.petersen@xxxxxxxxxx>:
>
>
> Keita,
>
> > When hpsa_scsi_add_host fails, h->lastlogicals is leaked since it lacks
> > free in the error handler.
> >
> > Fix this by adding free when hpsa_scsi_add_host fails.
> >
> > This patch also renames the numbered labels to detailed names.
>
> While I am no fan of numbered labels, these initialization stages are
> referenced several other places in the driver. As a result, renaming the
> labels makes the rest of the code harder to follow.
>
> I suggest you submit a fix for just the leak. And then, if the hpsa
> maintainers agree, we can entertain a separate patch to improve the
> naming.
>
> Thank you!
>
> --
> Martin K. Petersen      Oracle Linux Engineering