Re: [PATCH] staging: rtl8723bs: Replace the comparision method
From: kernel test robot
Date: Mon Oct 26 2020 - 22:46:27 EST
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/staging-rtl8723bs-Replace-the-comparision-method/20201027-061116
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9ab476ba001ead1f64430a3a61c9466ac0fa91ed
config: powerpc64-randconfig-r001-20201026 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f2c25c70791de95d2466e09b5b58fc37f6ccd7a4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/1be7587c45233c40c20f755e8da6867c36dde9ca
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review izabela-bakollari-gmail-com/staging-rtl8723bs-Replace-the-comparision-method/20201027-061116
git checkout 1be7587c45233c40c20f755e8da6867c36dde9ca
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
^
arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/staging/rtl8723bs/core/rtw_ap.c:9:
In file included from drivers/staging/rtl8723bs/include/drv_types.h:21:
In file included from drivers/staging/rtl8723bs/include/osdep_service.h:15:
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:19:
In file included from include/linux/netdevice.h:37:
In file included from include/linux/ethtool.h:18:
In file included from include/uapi/linux/ethtool.h:19:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:30:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/staging/rtl8723bs/core/rtw_ap.c:9:
In file included from drivers/staging/rtl8723bs/include/drv_types.h:21:
In file included from drivers/staging/rtl8723bs/include/osdep_service.h:15:
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:19:
In file included from include/linux/netdevice.h:37:
In file included from include/linux/ethtool.h:18:
In file included from include/uapi/linux/ethtool.h:19:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:32:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/staging/rtl8723bs/core/rtw_ap.c:9:
In file included from drivers/staging/rtl8723bs/include/drv_types.h:21:
In file included from drivers/staging/rtl8723bs/include/osdep_service.h:15:
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:19:
In file included from include/linux/netdevice.h:37:
In file included from include/linux/ethtool.h:18:
In file included from include/uapi/linux/ethtool.h:19:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:34:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/staging/rtl8723bs/core/rtw_ap.c:9:
In file included from drivers/staging/rtl8723bs/include/drv_types.h:21:
In file included from drivers/staging/rtl8723bs/include/osdep_service.h:15:
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:19:
In file included from include/linux/netdevice.h:37:
In file included from include/linux/ethtool.h:18:
In file included from include/uapi/linux/ethtool.h:19:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/powerpc/include/asm/io.h:604:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:36:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/staging/rtl8723bs/core/rtw_ap.c:1457:5: error: expected '(' after 'if'
if !(psetstakey_para) {
^
12 warnings and 1 error generated.
vim +1457 drivers/staging/rtl8723bs/core/rtw_ap.c
1442
1443 u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta)
1444 {
1445 struct cmd_obj *ph2c;
1446 struct set_stakey_parm *psetstakey_para;
1447 struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
1448 u8 res = _SUCCESS;
1449
1450 ph2c = rtw_zmalloc(sizeof(struct cmd_obj));
1451 if (!ph2c) {
1452 res = _FAIL;
1453 goto exit;
1454 }
1455
1456 psetstakey_para = rtw_zmalloc(sizeof(struct set_stakey_parm));
> 1457 if !(psetstakey_para) {
1458 kfree(ph2c);
1459 res = _FAIL;
1460 goto exit;
1461 }
1462
1463 init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
1464
1465 psetstakey_para->algorithm = (u8)psta->dot118021XPrivacy;
1466
1467 memcpy(psetstakey_para->addr, psta->hwaddr, ETH_ALEN);
1468
1469 memcpy(psetstakey_para->key, &psta->dot118021x_UncstKey, 16);
1470
1471 res = rtw_enqueue_cmd(pcmdpriv, ph2c);
1472
1473 exit:
1474
1475 return res;
1476 }
1477
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip