Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning

From: Xie He
Date: Tue Oct 27 2020 - 00:02:21 EST


On Mon, Oct 26, 2020 at 8:56 PM Xie He <xie.he.0141@xxxxxxxxx> wrote:
>
> > - for (mem = (HDW *) memmap; mem < (HDW *) (memmap + 1); ++mem)
> > + for (mem = (HDW *) memmap; mem < (HDW *) ((uintptr_t)memmap + 1); ++mem)
>
> Note that these two lines are semantically different. In the first line,
> "+ 1" moves the pointer by (sizeof memmap) bytes. However in the second
> line, "+ 1" moves the pointer by only 1 byte.

Correction: in the first line "+ 1" moves the pointer by (sizeof *memmap) bytes.