Re: [PATCH 11/14] USB: serial: keyspan_pda: clean up xircom/entrega support

From: Johan Hovold
Date: Tue Oct 27 2020 - 04:09:20 EST


On Mon, Oct 26, 2020 at 01:00:02PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-10-25 18:45:57 [+0100], Johan Hovold wrote:
> > Drop the separate Kconfig symbol for Xircom / Entrega and always include
> > support in the keyspan_pda driver.
> >
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> > drivers/usb/serial/Kconfig | 19 ++-------
> > drivers/usb/serial/Makefile | 1 -
> > drivers/usb/serial/keyspan_pda.c | 68 +++++---------------------------
> > 3 files changed, 13 insertions(+), 75 deletions(-)
> >
> > diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
> > index 4007fa25a8ff..a21ff5ab6df9 100644
> > --- a/drivers/usb/serial/Kconfig
> > +++ b/drivers/usb/serial/Kconfig
> > @@ -538,17 +538,6 @@ config USB_SERIAL_CYBERJACK
> >
> > If unsure, say N.
> >
> > -config USB_SERIAL_XIRCOM
>
> Should this patch remove this symbol from defconfigs or does it happen
> every now and then on its own? All of them select USB_SERIAL_KEYSPAN_PDA
> so there is no loss.

Good catch, thanks! I'll remove those config entries as part of this
patch.

Johan