Re: [PATCH v2] sched/fair: check for idle core

From: Julia Lawall
Date: Tue Oct 27 2020 - 06:00:39 EST




On Tue, 27 Oct 2020, Mel Gorman wrote:

> On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote:
> > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in wakeup path")
> > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
> > Reviewed-by Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> >
>
> While not a universal win, it was mostly a win or neutral. In few cases
> where there was a problem, one benchmark I'm a bit suspicious of generally
> as occasionally it generates bad results for unknown and unpredictable
> reasons. In another, it was very machine specific and the differences
> were small in absolte time rather than relative time. Other tests on the
> same machine were fine so overall;

Thanks for testing!

julia

>
> Acked-by: Mel Gorman <mgorman@xxxxxxx>
>
> Thanks.
>
> --
> Mel Gorman
> SUSE Labs
>