Re: [Cocci] Coccinelle: Checking the relevance of parentheses in “git grep”

From: Julia Lawall
Date: Tue Oct 27 2020 - 06:56:01 EST




On Tue, 27 Oct 2020, Markus Elfring wrote:

> > Will any adjustments become relevant then accordingly?
>
> I have found out that the function “interpret” (OCaml code) constructs a command
> and executes it.
> https://github.com/coccinelle/coccinelle/blob/3c01dc1696dc5ccfb319673f205e491b572ee0be/parsing_cocci/git_grep.ml#L9
>
> I have tried a corresponding test display out. Thus I have got the impression
> that desired patterns are passed with extra parentheses.
>
> … git grep -l -w \( -e for_each_node_by_type … -e for_each_node_with_property \) -- '*.c'
>
>
> How do you think about to omit these parentheses here?

Does it make a difference?

julia