Re: [PATCH v8 04/14] ASoC: sun4i-i2s: Set sign extend sample

[Maxime Ripard]

On Mon, Oct 26, 2020 at 07:52:29PM +0100, Clément Péron wrote:
> From: Marcus Cooper <codekipper@xxxxxxxxx>
> 
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
> 
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
> 
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep consistency and avoid relying on
> default.
> 
> Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx>
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> Signed-off-by: Clément Péron <peron.clem@xxxxxxxxx>

Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>

Maxime

Attachment: signature.asc
Description: PGP signature