Re: [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
From: Konstantin Aladyshev
Date: Tue Oct 27 2020 - 17:01:00 EST
These changes got picked up from my backport patch to the 'dev-5.8'
branch of the OpenBMC Linux repository.
This patch also needed to be added to the main ASPEED Linux kernel, so
it could get into subsequent branches of the OpenBMC Linux repository.
Best regards,
Konstantin Aladyshev
On Tue, Oct 27, 2020 at 5:10 PM Supreeth Venkatesh
<supreeth.venkatesh@xxxxxxx> wrote:
>
> These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel.
> Please abandon these changes.
>
> Thanks,
> Supreeth
>
> On 10/27/20 7:37 AM, Konstantin Aladyshev wrote:
> > [CAUTION: External Email]
> >
> > KCS nodes compatible property in the 'aspeed-g5.dtsi' file was
> > changed to use v2 binding in the commit fa4c8ec6feaa
> > ("ARM: dts: aspeed: Change KCS nodes to v2 binding").
> > For the proper initialization of /dev/ipmi-kcs* devices
> > KCS node variables also need to be changed to use v2 binding.
> >
> > Signed-off-by: Konstantin Aladyshev <aladyshev22@xxxxxxxxx>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > index 60ba86f3e5bc..89ddc3847222 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > @@ -139,17 +139,17 @@
> >
> > &kcs1 {
> > status = "okay";
> > - kcs_addr = <0x60>;
> > + aspeed,lpc-io-reg = <0x60>;
> > };
> >
> > &kcs2 {
> > status = "okay";
> > - kcs_addr = <0x62>;
> > + aspeed,lpc-io-reg = <0x62>;
> > };
> >
> > &kcs4 {
> > status = "okay";
> > - kcs_addr = <0x97DE>;
> > + aspeed,lpc-io-reg = <0x97DE>;
> > };
> >
> > &lpc_snoop {
> > --
> > 2.17.1
> >