Re: [PATCH 2/2] tools, bpftool: Remove two unused variables.

From: Andrii Nakryiko
Date: Wed Oct 28 2020 - 18:48:11 EST


On Tue, Oct 27, 2020 at 4:37 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Avoid an unused variable warning.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

> tools/bpf/bpftool/skeleton/profiler.bpf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/bpf/bpftool/skeleton/profiler.bpf.c b/tools/bpf/bpftool/skeleton/profiler.bpf.c
> index 4e3512f700c0..ce5b65e07ab1 100644
> --- a/tools/bpf/bpftool/skeleton/profiler.bpf.c
> +++ b/tools/bpf/bpftool/skeleton/profiler.bpf.c
> @@ -70,7 +70,7 @@ int BPF_PROG(fentry_XXX)
> static inline void
> fexit_update_maps(u32 id, struct bpf_perf_event_value *after)
> {
> - struct bpf_perf_event_value *before, diff, *accum;
> + struct bpf_perf_event_value *before, diff;
>
> before = bpf_map_lookup_elem(&fentry_readings, &id);
> /* only account samples with a valid fentry_reading */
> @@ -95,7 +95,7 @@ int BPF_PROG(fexit_XXX)
> {
> struct bpf_perf_event_value readings[MAX_NUM_MATRICS];
> u32 cpu = bpf_get_smp_processor_id();
> - u32 i, one = 1, zero = 0;
> + u32 i, zero = 0;
> int err;
> u64 *count;
>
> --
> 2.29.0.rc2.309.g374f81d7ae-goog
>