Re: [PATCH] opp: Reduce the size of critical section in _opp_table_kref_release()

From: Viresh Kumar
Date: Thu Oct 29 2020 - 03:37:54 EST


On 28-10-20, 16:32, Stephen Boyd wrote:
> Quoting Viresh Kumar (2020-10-27 00:57:06)
> > There is a lot of stuff here which can be done outside of the big
> > opp_table_lock, do that. This helps avoiding few circular dependency
> > lockdeps around debugfs and interconnects.
> >
> > Reported-by: Rob Clark <robdclark@xxxxxxxxx>
> > Reported-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > ---
>
> Any Fixes tag?

The circular dependency lockdep appears with 5.11 stuff and so we
don't need to fix it in any of the earlier releases. And so I didn't
wanted to bother with the fixes tag, as the code had been like this
for ever.

> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx>

Thanks a lot. I was a bit worried about the crazy idea I had to solve
this :)

--
viresh