RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

[Gloria Tsai]

Correct, it's device SRAM.


Regards,
Gloria Tsai
_____________________________________

Sales PM Division
Solid State Storage Technology Corporation
TEL: +886-3-612-3888 ext. 2201
E-Mail: gloria.tsai@xxxxxxxxx
_____________________________________

-----Original Message-----
From: Keith Busch <kbusch@xxxxxxxxxx> 
Sent: Thursday, October 29, 2020 11:15 AM
To: Gloria Tsai <Gloria.Tsai@xxxxxxxxx>
Cc: Jongpil Jung <jongpuls@xxxxxxxxx>; Sagi Grimberg <sagi@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx; Jens Axboe <axboe@xxxxxx>; dj54.sohn@xxxxxxxxxxx; jongpil19.jung@xxxxxxxxxxx; jongheony.kim@xxxxxxxxxxx; Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001



This message was sent from outside of the company. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe.


On Thu, Oct 29, 2020 at 11:33:06AM +0900, Keith Busch wrote:
> On Thu, Oct 29, 2020 at 02:20:27AM +0000, Gloria Tsai wrote:
> > Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
> > Do GC before shutdown -> delete IO Q -> shutdown from host -> 
> > breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use 
> > wrong pointer on device SRAM -> over program
>
> What do you mean by "wrong pointer"? At the place in the sequence 
> you're referring to, the PCI BME is disabled: you can't access *any* 
> host RAM, so there's no "correct" pointer either.

Re-reading your message, I do see you said "device" rather than "host", so my response may not be relevant.