Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

From: Herbert Xu
Date: Thu Oct 29 2020 - 05:14:56 EST


On Wed, Oct 28, 2020 at 10:06:58AM +0100, Ard Biesheuvel wrote:
>
> Not sure what is happening here: IIRC the intention was to rely on the
> fact that only the sync cbc(aes) implementation needs the fallback,
> and therefore, allocating a sync skcipher explicitly would avoid this
> recursion.
>
> Herbert?

It works only if everything is built in. If cbc is built as a
module then you need Horia's patch to prevent a loop.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt