Re: [PATCH v1 1/2] ASoC: qcom: dt-bindings: Add SM8250 sound card bindings

[Srinivas Kandagatla]

On 28/10/2020 18:24, Rob Herring wrote:
> On Wed, Oct 28, 2020 at 10:19 AM Srinivas Kandagatla
> <srinivas.kandagatla@xxxxxxxxxx> wrote:
> > On 28/10/2020 15:01, Rob Herring wrote:
> > > > +        - const: qcom,sm8250
> > >
> > > This collides with the top level SoC compatible resulting in:
> >
> > I did run dt_binding_check before sending out this patch, I might have
> > missed it somehow because the make dt_binding_check did not
> > end/termnitate in any errors, however if I had scrolled 15-20 Page ups
> > it does have this error log!
>
> make -sk

Thanks for the hint!

> :)
>
> > Documentation/devicetree/bindings/arm/qcom.yaml does have
> > qcom,qrb5165-rb5 entry under [qcom,sm8250]
> >
> > Can you help me understand why is this not a valid compatible?
>
> Those compatibles are used at the top level for the SoC. You can't use
> the same compatible to mean 2 different things.
Thanks for explaining this, This is now modified to
 "qcom,qrb5165-rb5-sndcard"
 "qcom,sm8250-sndcard"

I do not see any complains from dt_binding_check.

also makes it inline with other qcom soundcard compatible strings!

--srini
> Rob