Re: [PATCH -next] platform/x86/dell-wmi-sysman: Make some symbols static

[Andy Shevchenko]

On Thu, Oct 29, 2020 at 1:22 PM Zou Wei <zou_wei@xxxxxxxxxx> wrote:
>
> Fix the following sparse warnings:
>
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23:
> warning: symbol 'po_is_pass_set' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning:
> symbol 'po_current_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23:
> warning: symbol 'po_new_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23:
> warning: symbol 'po_min_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23:
> warning: symbol 'po_max_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23:
> warning: symbol 'po_mechanism' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23:
> warning: symbol 'po_role' was not declared. Should it be static?
>
> po_is_pass_set, po_current_password, po_new_password,
> po_min_pass_length, po_max_pass_length, po_mechanism and po_role
> have only call within passobj-attributes.c
> They should be static

I think at the same time you may put all of them in a way that each
occupies only a single line.

...

> -struct kobj_attribute po_role =
> +static struct kobj_attribute po_role =
>         __ATTR_RO(role);


-- 
With Best Regards,
Andy Shevchenko