Re: [PATCH v3] AMD_SFH: Fix for incorrect Sensor index

From: Jiri Kosina
Date: Thu Oct 29 2020 - 11:03:22 EST


On Wed, 28 Oct 2020, Sandeep Singh wrote:

> From: Sandeep Singh <sandeep.singh@xxxxxxx>
>
> It appears like the accelerometer/magnetometer and gyroscope
> indices were interchanged in the patch series which got into
> for-5.11/amd-sfh-hid until Mandoli/Richard reported to us.
> Ideally sensor indices should be 0,1,2 for the accelerometer,
> Gyroscope, Magnetometer respectively, but this interchanged
> possibly could be because i was using a test MP2 firmware
> on my machine.
>
> This patch fixes the earlier commit with the right sensor
> indices and also removing unused structures
> _hid_report_descriptor,
> _hid_device_descriptor as reported by Richard.
>
> Reported-by: Mandoli <lipheng@xxxxxxxxxxx>
> Reported-by: Richard Neumann <mail@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sandeep Singh <sandeep.singh@xxxxxxx>
> Fixes: SFH: PCIe driver to add support of AMD sensor fusion hub (4f567b9f8141)

I've modified the Fixes: tag so that it has proper format and applied,
thanks.

--
Jiri Kosina
SUSE Labs