drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit declaration of function 'msm_dp_display_pre_disable'; did you mean

[kernel test robot]

Hi Kuogee,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   07e0887302450a62f51dba72df6afb5fabb23d1c
commit: 8ede2ecc3e5ee327923f6e3cfe52761ce73607d1 drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets
date:   6 weeks ago
config: arm64-randconfig-r032-20201030 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8ede2ecc3e5ee327923f6e3cfe52761ce73607d1
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 8ede2ecc3e5ee327923f6e3cfe52761ce73607d1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function 'dpu_encoder_virt_mode_set':
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:981:31: warning: variable 'num_dspp' set but not used [-Wunused-but-set-variable]
     981 |  int num_lm, num_ctl, num_pp, num_dspp;
         |                               ^~~~~~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:976:30: warning: variable 'topology' set but not used [-Wunused-but-set-variable]
     976 |  struct msm_display_topology topology;
         |                              ^~~~~~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function '_dpu_encoder_virt_enable_helper':
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1099:26: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
    1099 |  struct msm_drm_private *priv;
         |                          ^~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function 'dpu_encoder_virt_disable':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit declaration of function 'msm_dp_display_pre_disable'; did you mean 'msm_dp_display_disable'? [-Werror=implicit-function-declaration]
    1229 |   if (msm_dp_display_pre_disable(priv->dp, drm_enc))
         |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |       msm_dp_display_disable
   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1203:18: warning: variable 'dpu_kms' set but not used [-Wunused-but-set-variable]
    1203 |  struct dpu_kms *dpu_kms;
         |                  ^~~~~~~
   cc1: some warnings being treated as errors

vim +1229 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

  1198	
  1199	static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
  1200	{
  1201		struct dpu_encoder_virt *dpu_enc = NULL;
  1202		struct msm_drm_private *priv;
  1203		struct dpu_kms *dpu_kms;
  1204		int i = 0;
  1205	
  1206		if (!drm_enc) {
  1207			DPU_ERROR("invalid encoder\n");
  1208			return;
  1209		} else if (!drm_enc->dev) {
  1210			DPU_ERROR("invalid dev\n");
  1211			return;
  1212		}
  1213	
  1214		dpu_enc = to_dpu_encoder_virt(drm_enc);
  1215		DPU_DEBUG_ENC(dpu_enc, "\n");
  1216	
  1217		mutex_lock(&dpu_enc->enc_lock);
  1218		dpu_enc->enabled = false;
  1219	
  1220		priv = drm_enc->dev->dev_private;
  1221		dpu_kms = to_dpu_kms(priv->kms);
  1222	
  1223		trace_dpu_enc_disable(DRMID(drm_enc));
  1224	
  1225		/* wait for idle */
  1226		dpu_encoder_wait_for_event(drm_enc, MSM_ENC_TX_COMPLETE);
  1227	
  1228		if (drm_enc->encoder_type == DRM_MODE_ENCODER_TMDS && priv->dp) {
> 1229			if (msm_dp_display_pre_disable(priv->dp, drm_enc))
  1230				DPU_ERROR_ENC(dpu_enc, "dp display push idle failed\n");
  1231		}
  1232	
  1233		dpu_encoder_resource_control(drm_enc, DPU_ENC_RC_EVENT_PRE_STOP);
  1234	
  1235		for (i = 0; i < dpu_enc->num_phys_encs; i++) {
  1236			struct dpu_encoder_phys *phys = dpu_enc->phys_encs[i];
  1237	
  1238			if (phys->ops.disable)
  1239				phys->ops.disable(phys);
  1240		}
  1241	
  1242	
  1243		/* after phys waits for frame-done, should be no more frames pending */
  1244		if (atomic_xchg(&dpu_enc->frame_done_timeout_ms, 0)) {
  1245			DPU_ERROR("enc%d timeout pending\n", drm_enc->base.id);
  1246			del_timer_sync(&dpu_enc->frame_done_timer);
  1247		}
  1248	
  1249		dpu_encoder_resource_control(drm_enc, DPU_ENC_RC_EVENT_STOP);
  1250	
  1251		for (i = 0; i < dpu_enc->num_phys_encs; i++) {
  1252			dpu_enc->phys_encs[i]->connector = NULL;
  1253		}
  1254	
  1255		DPU_DEBUG_ENC(dpu_enc, "encoder disabled\n");
  1256	
  1257		if (drm_enc->encoder_type == DRM_MODE_ENCODER_TMDS && priv->dp) {
  1258			if (msm_dp_display_disable(priv->dp, drm_enc))
  1259				DPU_ERROR_ENC(dpu_enc, "dp display disable failed\n");
  1260		}
  1261	
  1262		mutex_unlock(&dpu_enc->enc_lock);
  1263	}
  1264	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip