Re: [PATCH 2/9] arm64: dts: ls1088ardb: add QSGMII PHY nodes

[Ioana Ciornei]

On Fri, Oct 30, 2020 at 08:07:26AM +0800, Shawn Guo wrote:
> On Fri, Sep 25, 2020 at 04:24:56PM +0300, Ioana Ciornei wrote:
> > Annotate the external MDIO1 node and describe the 8 QSGMII PHYs found on
> > the LS1088ARDB board and add phy-handles for DPMACs 3-10 to its
> > associated PHY.  Also, add the internal PCS MDIO nodes for the internal
> > MDIO buses found on the LS1088A SoC along with their internal PCS PHY
> > and link the corresponding DPMAC to the PCS through the pcs-handle.
> > 
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > ---
> >  .../boot/dts/freescale/fsl-ls1088a-rdb.dts    | 100 ++++++++++++++++++
> >  .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi |  50 +++++++++
> >  2 files changed, 150 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > index 5633e59febc3..d7886b084f7f 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > @@ -17,6 +17,98 @@ / {
> >  	compatible = "fsl,ls1088a-rdb", "fsl,ls1088a";
> >  };

(...)

> > +&emdio1 {
> > +	status = "okay";
> > +
> > +	mdio1_phy1: emdio1_phy@1 {
> 
> If this is an Ethernet PHY device, please use generic node name like
> 'ethernet-phy'.  Also the unit-address in node name should match 'reg'
> property.

Yes, it is. I'll rename them and use the reg as the unit-address.

(...)

> > +		pcs_mdio3: mdio@8c0f000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x0 0x8c0f000 0x0 0x1000>;
> > +			little-endian;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			status = "disabled";
> > +
> > +			pcs3_0: pcs-phy@0 {
> 
> ethernet-phy@0?
> 

Will change.

Ioana