Re: [PATCH 1/9] mfd: maxim: remove unnecessary CONFIG_PM_SLEEP

From: Coiby Xu
Date: Fri Oct 30 2020 - 11:01:55 EST


On Thu, Oct 29, 2020 at 07:32:26PM +0100, Krzysztof Kozlowski wrote:
On Thu, Oct 29, 2020 at 06:06:39PM +0800, Coiby Xu wrote:
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

I don't quite get what did you mean by "took good care". This should
cause warnings of unused structure. Comment applies to other patches as
well.

Sorry I made a mistake.
Also, the title prefix is: "mfd: max77686:"

Thank you for the reminding! I'll improve my script to avoid this issue
when extracting prefix from git log.

Best regards,
Krzysztof



Signed-off-by: Coiby Xu <coiby.xu@xxxxxxxxx>
---
drivers/mfd/max77686.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 71faf503844b..8c701f8a9dd5 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -227,7 +227,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
return 0;
}

-#ifdef CONFIG_PM_SLEEP
static int max77686_suspend(struct device *dev)
{
struct i2c_client *i2c = to_i2c_client(dev);
@@ -262,7 +261,6 @@ static int max77686_resume(struct device *dev)

return 0;
}
-#endif /* CONFIG_PM_SLEEP */

static SIMPLE_DEV_PM_OPS(max77686_pm, max77686_suspend, max77686_resume);

--
2.28.0


--
Best regards,
Coiby