Re: [PATCH v2 2/3] dt-bindings: mfd: Add QCOM PM8008 MFD bindings

[Rob Herring]

On Thu, Oct 22, 2020 at 02:35:41PM -0700, Guru Das Srinagesh wrote:
> Add device tree bindings for the driver for Qualcomm Technology Inc.'s
> PM8008 MFD PMIC.
> 
> Signed-off-by: Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> ---
>  .../bindings/mfd/qcom,pm8008-irqchip.yaml          | 102 +++++++++++++++++++++
>  1 file changed, 102 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8008-irqchip.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008-irqchip.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008-irqchip.yaml
> new file mode 100644
> index 0000000..31d7b68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008-irqchip.yaml
> @@ -0,0 +1,102 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/qcom,pm8008-irqchip.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. PM8008 Multi-Function Device PMIC
> +
> +maintainers:
> +  - Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> +
> +description: |
> +  PM8008 is a PMIC that contains 7 LDOs, 2 GPIOs, temperature monitoring, and
> +  can be interfaced over I2C.

No bindings for all those functions? Bindings should be complete.

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: qcom,pm8008-irqchip

Why irqchip?

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - const: pm8008
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  "#address-cells":
> +    const: 1
> +    description: Must be specified if child nodes are specified.
> +
> +  "#size-cells":
> +    const: 0
> +    description: Must be specified if child nodes are specified.
> +
> +  "#interrupt-cells":
> +    const: 2
> +    description: |
> +      The first cell is the IRQ number, the second cell is the IRQ trigger flag.
> +
> +patternProperties:
> +  "^.*@[0-9a-f]+$":

'^.*' can be dropped. That's redundant.

> +    type: object
> +    # Each peripheral in PM8008 must be represented as a child node with an
> +    # optional label for referencing as phandle elsewhere. This is optional.
> +    properties:
> +      compatible:
> +        description: The compatible string for the peripheral's driver.
> +
> +      reg:
> +        maxItems: 1

What does the address represent? It's non-standard, so it needs to be 
defined.

> +
> +      interrupts:
> +        maxItems: 1
> +
> +    required:
> +      - compatible
> +      - reg
> +      - interrupts
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    qupv3_se13_i2c {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            pm8008i@8 {
> +                    compatible = "qcom,pm8008-irqchip";
> +                    reg = <0x8>;
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    interrupt-controller;
> +                    #interrupt-cells = <2>;
> +
> +                    interrupt-names = "pm8008";
> +                    interrupt-parent = <&tlmm>;
> +                    interrupts = <32 IRQ_TYPE_EDGE_RISING>;
> +
> +                    pm8008_tz: qcom,temp-alarm@2400 {

Must be documented.

And don't use vendor prefixes in node names. 

> +                            compatible = "qcom,spmi-temp-alarm";
> +                            reg = <0x2400>;
> +                            interrupts = <0x5 IRQ_TYPE_EDGE_BOTH>;
> +                            #thermal-sensor-cells = <0>;
> +                    };
> +            };
> +    };
> +
> +...
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>