Re: Linux 4.19.153

[Eddie Chapman]

On 30/10/2020 14:44, Sasha Levin wrote:
> On Fri, Oct 30, 2020 at 10:14:16AM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Oct 30, 2020 at 09:49:15AM +0100, Greg Kroah-Hartman wrote:
> > > On Fri, Oct 30, 2020 at 09:26:54AM +0100, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > > > I'm announcing the release of the 4.19.153 kernel.
> > > > >
> > > > > All users of the 4.19 kernel series must upgrade.
> > > > >
> > > > > The updated 4.19.y git tree can be found at:
> > > > >     
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
> > > linux-4.19.y
> > > > > and can be browsed at the normal kernel.org git web browser:
> > > > >     
> > > https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary 
> > >
> > > >
> > > > Did something go seriously wrong here?
> > > >
> > > > The original 4.19.153-rc1 series had 264 patches. "powerpc/tau: Remove
> > > > duplicated set_thresholds() call" is 146/264 of the series, but it is
> > > > last one in 4.19.153 as released. "178/264 ext4: limit entries
> > > > returned when counting...", for example, is not present in
> > > > 4.19.153... as are others, for example "net: korina: cast KSEG0
> > > > address to pointer in kfree". Looks like 118 or so patches are
> > > > missing.
> > > >
> > > > They are not in origin/queue/4.19, either.
> > >
> > > Wow, something did go wrong here, thanks for catching this.
> > >
> > > Let me dig and see what happened, the whole series did not apply, which
> > > makes me wonder if the same thing happened for other branches as well...
> > >
> > > thanks for checking up and finding this.
> > >
> > > Give me a bit...
> >
> > Ok, figure3d it out.
> >
> > Sasha changed a powerpc patch to build properly but didn't realize that
> > later powerpc patches would not apply because of that.  I didn't run my
> > "apply all patches to make sure they are clean" script before doing the
> > release after he did that, so 'git quiltimport' failed when applying the
> > series at the place where the powerpc path failed to apply.
> >
> > My scripts don't check for the result of 'git quiltimport' being
> > successful or not (I don't even know if it return an error for this type
> > of thing), and just moved on in the release process.
> >
> > I'll go do a new 4.19 release with the rest of the patches missed here,
> > thank you for finding this.
> >
> > And I'll go make my release scripts more robust to failures like this as
> > well.
> >
> > thanks so much!
>
> You're right, sorry :( And thanks Pavel!

Hey Greg and Sasha, just want to express my gratitude for all the work 
you guys do maintaining a gazillion stable kernels :-) There is bound to 
be a hiccup in the process every once in a while.