[PATCH 01/12] mm/mempolicy: Add comment for missing LOCAL
From: Ben Widawsky
Date: Fri Oct 30 2020 - 15:02:47 EST
MPOL_LOCAL is a bit weird because it is simply a different name for an
existing behavior (preferred policy with no node mask). It has been this
way since it was added here:
commit 479e2802d09f ("mm: mempolicy: Make MPOL_LOCAL a real policy")
It is so similar to MPOL_PREFERRED in fact that when the policy is
created in mpol_new, the mode is set as PREFERRED, and an internal state
representing LOCAL doesn't exist.
To prevent future explorers from scratching their head as to why
MPOL_LOCAL isn't defined in the mpol_ops table, add a small comment
explaining the situations.
v2:
Change comment to refer to mpol_new (Michal)
Link: https://lore.kernel.org/r/20200630212517.308045-2-ben.widawsky@xxxxxxxxx
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Signed-off-by: Ben Widawsky <ben.widawsky@xxxxxxxxx>
---
mm/mempolicy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 3fde772ef5ef..e24f0133ff1f 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -427,6 +427,7 @@ static const struct mempolicy_operations mpol_ops[MPOL_MAX] = {
.create = mpol_new_bind,
.rebind = mpol_rebind_nodemask,
},
+ /* [MPOL_LOCAL] - see mpol_new() */
};
static int migrate_page_add(struct page *page, struct list_head *pagelist,
--
2.29.2