Re: [PATCH net-next v4 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

[Xie He]

On Fri, Oct 30, 2020 at 2:12 PM Willem de Bruijn
<willemdebruijn.kernel@xxxxxxxxx> wrote:
>
> Jakub recently made stats behavior less ambiguous, in commit
> 0db0c34cfbc9 ("net: tighten the definition of interface statistics").
>
> That said, it's not entirely clear whether rx_dropped would be allowed
> to include rx_errors.
>
> My hunch is that it shouldn't. A quick scan of devices did quickly
> show at least one example where it does: macvlan. But I expect that to
> be an outlier.

OK. Thanks for the information.

> Please do always consider backward compatibility. In this case, I
> don't think that the behavioral change is needed for the core of the
> patch (changing control flow).

OK. I'll drop the change about stats.rx_dropped. Thanks.