Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword

[Florian Fainelli]

On 10/30/2020 6:48 PM, Zou Wei wrote:
> Fix the following sparse warning:
> 
> ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
> 
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
> Mark it static as suggested.
> 
> Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")

Not sure if the Fixes: tag is entirely appropriate here, but sure, why not.

> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
-- 
Florian